Repository navigation
Ask people to agree to the terms and privacy policy before they sign in - #82
Open
shanerbaner82 wants to merge 1 commit into
Open
shanerbaner82 wants to merge 1 commit into
shanerbaner82 wants to merge 1 commit into
Conversation
Neither Sign in with GitHub nor Sign in with Apple works until the box is ticked, and links open the terms and privacy policy in the app's browser. The phone tells devnull which version it showed as it signs in (terms_version), which devnull records. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sign-in screen has a checkbox, "I agree to the terms of service and privacy policy. There's no tolerance for objectionable content or abusive users.", with links to both pages (dev-null.sh/terms and /privacy, in the app's browser). Sign in with GitHub and Sign in with Apple stay disabled until it's ticked. This is what App Review's guideline 1.2 asks of an app with user-generated content.
The phone sends
terms_version(Client::TermsVersion, 2026-10-23) with the sign-in call for both ways in, so devnull records what was accepted.Depends on
dev-null-sh/dev-null.sh#1042, which records the version and updates the terms and privacy wording. Until it's merged the server ignores
terms_version; sign-in still works.Client::TermsVersionhas to match the server'sconfig('legal.terms_version'), or the server answers 422.Not in this PR
People already signed in on a phone aren't asked. The server now says in
GET /mewhether they accepted the version in force (terms_accepted), so a gate for them can follow.Verified
Pest passes (1189, arch test excluded). Checked on the iPhone 17 Pro simulator: buttons grey until the box is ticked, then enabled.
🤖 Generated with Claude Code