Repository navigation
Put Cancel and Commit in a bar at the top of the commit sheet - #19
Merged
simonhamp merged 2 commits intoOct 20, 2026
Merged
Conversation
KaitoMuraoka
marked this pull request as ready for review
October 19, 2026 17:17
Member
|
can you fix the conflicts? |
The new commit and quote sheets have Cancel, the title and Commit in a bar along the top, pinned outside the scroll view so it stays while the field scrolls. native-ui's bottom sheet has no toolbar, so the bar is a row. On iOS, Cancel is a Liquid Glass button and Commit a prominent one in your colour, as the HIG's sheet toolbars float over content. On Android they're text buttons, as in Material 3's full-screen dialog header. The two buttons are the same width with the same padding either side, so the title sits in the middle, and both they and the 56pt bar grow with larger text rather than clipping. Android's sheet already has Material 3's drag handle above its content, so only iOS gets room above the bar. Cancel closes the sheet as a swipe does, and the draft stays stashed. Why devnull didn't take a commit now shows above the field, near Commit, rather than under the quoted card where the keyboard can hide it.
Contributor
Author
|
Yes! I'm working on that right now. |
KaitoMuraoka
force-pushed
the
feature/commit-sheet-toolbar
branch
from
October 20, 2026 11:51
0a14f74 to
1d90aaa
Compare
Cancel tells VoiceOver and TalkBack that it keeps the draft for next time, since its name suggests otherwise. hideCommitSheet's docblock now says Cancel uses it too and that it mustn't forget the draft. Whether a body is long enough to commit is Commit::fits(), which the sheet's Commit button and commitFromSheet() both ask, so the button can't be enabled for a body the sheet won't send.
KaitoMuraoka
force-pushed
the
feature/commit-sheet-toolbar
branch
from
October 20, 2026 11:52
1d90aaa to
8b2bdab
Compare
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new commit and quote sheets now have Cancel, the title and Commit in a bar along the top, the way compose sheets look on each platform. native-ui's bottom sheet has no toolbar, so the bar is a row pinned outside the scroll view, and it stays put while the field scrolls.
ios:glass,ios:glass:prominent), following the HIG's sheet toolbars.stash@{0}, and ana11y-hinttells VoiceOver and TalkBack so.Commit::fits()holds the length check, which the Commit button andcommitFromSheet()both use.Testing
php artisan test --compact --filter='ComposeSheet|Quote|DraftStash|Saved': 67 passedNot covered
.toolbarand M3'sTopAppBarwould need a plugin or a change to native-ui upstream.ScreenShot
References
Explanation in Japanese
概要
新しいコミットシートと引用シートでは、キャンセル・タイトル・コミットが上部のバーに並ぶようになりました。各プラットフォームの作成(compose)シートと同じ見た目です。native-ui のボトムシートにはツールバーがありません。そのため、このバーはスクロールビューの外に固定した行として実装しており、入力欄をスクロールしても動きません。
ios:glass、ios:glass:prominent)。stash@{0}の印付きで戻ってきます。このことはa11y-hintで VoiceOver と TalkBack に伝えます。Commit::fits()にまとめ、コミットボタンとcommitFromSheet()の両方から使っています。テスト
php artisan test --compact --filter='ComposeSheet|Quote|DraftStash|Saved': 67 件成功対象外
.toolbarや M3 のTopAppBarに移行するには、プラグインを作るか、native-ui の upstream を変更する必要があります。参考資料