fix: avoid mutable default in ContextVar and safely retrieve tasks - #964
Open
aoright wants to merge 1 commit into
Open
fix: avoid mutable default in ContextVar and safely retrieve tasks#964aoright wants to merge 1 commit into
aoright wants to merge 1 commit into
Conversation
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
var.py中的comment_tasks_var默认值从可变列表default=[]改为default=None,避免在多个异步上下文之间意外共享和修改同一列表实例。media_platform/kuaishou/core.py中使用comment_tasks_var.get() or []安全提取当前运行任务。tools/time_util.py中未使用的异常捕获变量和多余的pass语句。