[2026 Plugins] Verify plugin signatures and trust metadata - #761
Open
Godfrey-Delight wants to merge 1 commit into
Open
[2026 Plugins] Verify plugin signatures and trust metadata#761Godfrey-Delight wants to merge 1 commit into
Godfrey-Delight wants to merge 1 commit into
Conversation
|
@Godfrey-Delight Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Authenticates plugin publishers and surfaces verification status prior to installation or dynamic execution in the registry and loader.
Closes #678
Type of Change
Changes Made
src/plugins/verifier.rsfor Ed25519 SHA-256 binary signature verification supporting Stellar StrKey public keys (G...) and hex formats.PluginManifestandInstalledPluginregistry schema to persistpublisher,publisher_key, andverification_statuswith backward-compatible defaults.PluginManager::load_plugin_diagnosed()to block execution of untrusted or invalid plugin binaries beforelibloading.starforge pluginCLI commands (install,list,verify,audit,update) to display verification status and enforcerequire_signatures/trusted_publisherssettings.tests/plugin_signature_verification.rs) and updated developer guidance inPLUGIN_TRUST.md.Testing
How has this been tested?
Added dedicated integration test suite covering publisher authentication, key parsing, allowlists, and signature verification.
Test Coverage
Describe what scenarios have been tested:
--json), and auditing of valid signed plugins.trusted_publishersconfiguration.require_signatures = true).Code Quality Checklist
cargo fmt)cargo clippy -- -D warnings)Breaking Changes
starforge.db/plugins.jsonregistries via#[serde(default)]).Documentation
PLUGIN_TRUST.mdupdated with publisher signature schema and verification workflows.Screenshots (if applicable)
N/A (CLI output updated with
Verificationstatus columns and structured--jsonpayload fields).Additional Context
Fully satisfies issue requirements for verifying plugin signatures and trust metadata prior to execution.