Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 5d93e0d |
5d93e0d to
8c9cf08
Compare
|
/ok to test 8c9cf08 |
8c9cf08 to
5e23488
Compare
|
/ok to test 5e23488 |
5e23488 to
ac23351
Compare
|
/ok to test ac23351 |
ac23351 to
ab64cd0
Compare
|
/ok to test ab64cd0 |
ab64cd0 to
64db7b6
Compare
|
/ok to test 64db7b6 |
64db7b6 to
e6b9494
Compare
|
/ok to test e6b9494 |
e6b9494 to
f9e17de
Compare
|
/ok to test f9e17de |
f9e17de to
9248118
Compare
|
/ok to test 9248118 |
9248118 to
754c687
Compare
|
/ok to test 754c687 |
|
/ok to test f15e3ff |
f15e3ff to
9aee757
Compare
|
/ok to test 9aee757 |
9aee757 to
9e7d5aa
Compare
|
/ok to test 9e7d5aa |
janickm
left a comment
janickm
left a comment
There was a problem hiding this comment.
Running something like
bazel run //tools:ncore_export_camera --
--output-dir=/tmp/img_orig
--camera-id=camera_front_wide_120fov
--step-frame=1
--timestamp-image-names
--encode-video
#--rectify
#--rectify-fov-factor=1.4
v4
--component-group=/tmp/pai/pai_4f14b8f4-4c16-48ce-aa42-02add7cd9f4d/pai_4f14b8f4-4c16-48ce-aa42-02add7cd9f4d.json
on a non-existing .json it seems like there is a directory created and then we fail with
backend_zarr3.py", line 426, in open_root_group
raise KeyError(V2_CONSOLIDATED_METADATA_KEY)
KeyError: '.zmetadata.cbor.xz'
rather, we should fail to open with a proper error message
9e7d5aa to
b3835fc
Compare
|
/ok to test b3835fc |
|
Re running |
b3835fc to
b3ccd65
Compare
|
/ok to test b3ccd65 |
b3ccd65 to
8ef4526
Compare
|
/ok to test 8ef4526 |
8ef4526 to
3296db7
Compare
|
/ok to test 3296db7 |
Support zarr-python 3 (>= 3.1.4) next to zarr-python 2 for zarr format v2 data. The zarr-python version specific operations of nodes and stores are implemented by a zarr-python 3 backend (backend_zarr3.py), which is selected at import time: - zarr-python's coroutines run on an event loop owned by the calling thread (offloaded codec work runs inline), avoiding thread hand-offs to zarr-python's I/O thread per access. Forked processes create new loops, coroutines within running event loops run on zarr-python's I/O loop - a zarr-python 3 store of indexed tar archives; complete reads of arrays of archives stored as a single uncompressed chunk are views of the chunk record (no copies), as with zarr-python 2 - consolidated hierarchies are opened from the decoded compressed consolidated metadata (no node metadata reads), with node metadata ordered by parent group (zarr-python < 3.4 attaches members of a group to its first run of keys only, zarr-python#4226) Data written with zarr-python 2 and 3 is equivalent: chunk records are byte-identical, node metadata documents are equivalent JSON. zarr-python 3 rewrites node metadata on every update of a node, which the write-once records of indexed tar archives don't support. Node metadata records of archives opened for writing are now kept in memory and appended when closing the archive (parents first), independent of the zarr-python version. Test environments: python 3.11 uses zarr-python 3.1.4 (the oldest supported version), python 3.13 zarr-python 3.4, python 3.8 / 3.12 zarr-python 2. Type checking runs against zarr-python 3 (the zarr-python 2 backend is exempt from unresolved zarr-python 2 APIs). BREAKING CHANGE: node metadata records of indexed tar archives are appended when closing archives (after all chunk records), so archives are no longer byte-identical to archives written by ncore 19.8 (their records are).
3296db7 to
050e595
Compare
|
/ok to test 050e595 |
This branch has not been deployed
1 participant
Support zarr-python 3 (>= 3.1.4) next to zarr-python 2 for zarr format v2 data. The zarr-python version specific operations of nodes and stores are implemented by a zarr-python 3 backend (backend_zarr3.py), which is selected at import time:
Data written with zarr-python 2 and 3 is equivalent: chunk records are byte-identical, node metadata documents are equivalent JSON.
zarr-python 3 rewrites node metadata on every update of a node, which the write-once records of indexed tar archives don't support. Node metadata records of archives opened for writing are now kept in memory and appended when closing the archive (parents first), independent of the zarr-python version.
Test environments: python 3.11 uses zarr-python 3.1.4 (the oldest supported version), python 3.13 zarr-python 3.4, python 3.8 / 3.12 zarr-python 2. Type checking runs against zarr-python 3 (the zarr-python 2 backend is exempt from unresolved zarr-python 2 APIs).
BREAKING CHANGE: node metadata records of indexed tar archives are appended when closing archives (after all chunk records), so archives are no longer byte-identical to archives written by ncore 19.8 (their records are).