check length of 'root' string before writing to ctx->root - #386
Merged
Conversation
Closed
rahulait
reviewed
Aug 10, 2026
| .gid = gid, | ||
| .nvml_dl = NULL, | ||
| }; | ||
| if (strlen(root) > sizeof(ctx->root)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (strlen(root) > sizeof(ctx->root)) { | |
| if (strlen(root) >= sizeof(ctx->root)) { |
strcpy() writes a terminating NUL byte as well. We should allow one space for that.
Contributor
There was a problem hiding this comment.
@rajatchopra can we update this and then have it merged?
Contributor
|
Thanks @rajatchopra , the change LGTM. Can we squash the commits and sign them before we merge it? |
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
rajatchopra
force-pushed
the
rajatchopra-patch-1
branch
from
September 8, 2026 17:04
ff8aece to
2bee8f0
Compare
cdesiniotis
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.