Repository navigation
Conversation
Change mapUser-requested aggregation consolidation, slice 5/5. Observed requirement and smallest sufficient change: Add materialize_values and MaterializedValues so scalar features/generated targets are computed once into one enriched AnchorTable. Read projected source chunks through the existing custom-TT reader, reuse one prepared native plan, and stream typed output while preserving IDs, splits, metadata and external labels. Later native batches consume cached scalar columns while graph/history retrieval stays dynamic. The unchanged inspection/fitting route reuses the common kernel; there is no separate serving aggregation backend. Focused verification / stopping condition: Complete stack: 1,951 public tests passed (3 CUDA skips; 47 notebook deselections), 567 bounded native tests, and 221 Rust tests (3 existing ignores). Post-format executable documentation/native-cache tests: 30 passed. Package Ruff check and formatting pass. Matched warm-cache CPU benchmark (same typed scalar output writer, 65,536 anchors, 256-row chunks, one thread): original 244.1s, round1 171.5s, round2 164.0s, revised 153.1s; all output digests match. This is scalar compute+write, not model training. Anonymous peak was about 288 MiB plus about 52.45 GiB file-backed RSS; no memory-reduction claim. Final publication build: 400 Rust library tests, 567 native Python tests and 44 public materialization/cache/type/docs tests passed. Its scale rerun took 152.7s with the same exact output digest. strict Clippy passes for all targets in the three modified Rust crates. No model training or live BP sweep. Stop at this slice’s verified behavior; fitting redesign, new temporal/LP capabilities and live sweeps are separate.
Verified repair — 2026-11-11Head: Validation: repaired combined stack passed 146 Rust TT integration tests and 579 Python native/conformance tests with a freshly rebuilt extension. Public Python suite: 1,951 passed; optional-native import checks: two modules skipped as expected without DiskGraph. Generated artifact manifest and 403-component notice checks passed. No live sweeps or merges. Follow-up verified repair: Current head |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
16866c3 to
3e686bd
Compare
33a82dd to
98fa94e
Compare
Summary
Add materialize_values and MaterializedValues so scalar features/generated targets are computed once into one enriched AnchorTable. Read projected source chunks through the existing custom-TT reader, reuse one prepared native plan, and stream typed output while preserving IDs, splits, metadata and external labels. Later native batches consume cached scalar columns while graph/history retrieval stays dynamic. The unchanged inspection/fitting route reuses the common kernel; there is no separate serving aggregation backend.
Stack slice 5/5. Targets the preceding stack branch; merge in dependency order.
Change map
#283 (comment)
Testing
Complete stack: 1,951 public tests passed (3 CUDA skips; 47 notebook deselections), 567 bounded native tests, and 221 Rust tests (3 existing ignores). Post-format executable documentation/native-cache tests: 30 passed. Package Ruff check and formatting pass. Matched warm-cache CPU benchmark (same typed scalar output writer, 65,536 anchors, 256-row chunks, one thread): original 244.1s, round1 171.5s, round2 164.0s, revised 153.1s; all output digests match. This is scalar compute+write, not model training. Anonymous peak was about 288 MiB plus about 52.45 GiB file-backed RSS; no memory-reduction claim. Final publication build: 400 Rust library tests, 567 native Python tests and 44 public materialization/cache/type/docs tests passed. Its scale rerun took 152.7s with the same exact output digest. strict Clippy passes for all targets in the three modified Rust crates. No model training or live BP sweep.
Dependency order: #279 → #280 → #281 → #282 → #283.