You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Upgrade DiskGraph to arrow and parquet 60.1 - #193
Move every arrow-rs crate and parquet in DiskGraph from 59.3.2 to 60.1. Also remove a stale cargo update of time from docker/build_diskgraph_wheel; the lockfile already pins it.
Why
parquet 60 brings zstd 0.14, which clears RUSTSEC-2026-0391, -0398, -0403 and -0410.
Behavior change
parquet-rs 60 always marks float and double columns with IEEE 754 total order (apache/arrow-rs#9619), and pyarrow up to 24 ignores min/max statistics on such columns (apache/arrow#50807). The only effect is that a reader filtering on a float column reads every row group instead of skipping some. Kumo never does that: DiskGraph doesn't read float statistics, and our Python code reads these files whole or filters only on ID columns. Values are unchanged.
Cargo manifests upgrade Arrow and Parquet dependencies to version 60.1.0. Third-party notices and Linux and Windows artifact manifests record the updated dependency versions, including changes to Zstandard license details. The wheel build script removes the command that pinned time to version 0.3.47.
Pre-merge checks: 2 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Change Map Design Review
The required PR conversation comment beginning with <!-- kumo-pr-change-map --> is not present in the supplied review context. The repository contains only the template and checker references to tha…
Provide the full PR conversation comment beginning with <!-- kumo-pr-change-map -->, including its observed failure, design table, verification, and stopping condition. Then review each proposed change against the repository diff and link…
Passed checks: 2 passed
Check name
Status
Explanation
Pr Size
The pull request changes 14 files. This does not exceed the 40-file limit.
Public Resource Access
All added package-source references are publicly accessible. The new Arrow origin https://github.com/apache/arrow-rs in 3rdparty/notices/inventory.json:2508 returned HTTP 200. The added crates.io …
Full details: Public Resource Access
Explanation
All added package-source references are publicly accessible. The new Arrow origin https://github.com/apache/arrow-rs in 3rdparty/notices/inventory.json:2508 returned HTTP 200. The added crates.io registry source for arrow-cmp in packages/diskgraph/Cargo.lock:262 and the artifact manifests is public; the registry endpoint returned HTTP 200. Crates.io API checks returned HTTP 200 for every changed package/version, including arrow-cmp 60.1.0.
Full details: Change Map Design Review
Explanation
The required PR conversation comment beginning with <!-- kumo-pr-change-map --> is not present in the supplied review context. The repository contains only the template and checker references to that marker, not the author's Change map. Without that comment, I cannot assess whether each proposed change is necessary, correctly layered, behavior-preserving, or sufficiently verified.
Resolution
Provide the full PR conversation comment beginning with <!-- kumo-pr-change-map -->, including its observed failure, design table, verification, and stopping condition. Then review each proposed change against the repository diff and linked problem.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Review coverage is incomplete: 1 file could not be fully reviewed. Findings from completed review steps are included; see review info for details.
Move every arrow-rs crate and parquet from 59.3.2 to 60.1. No
code changes are needed, and parquet 60 brings zstd 0.14,
which clears four RUSTSEC advisories in zstd, zstd-safe and
zstd-sys. Regenerate Cargo.lock, the artifact manifest, the
notice inventory and THIRD-PARTY.txt.
Parquet files DiskGraph writes now mark float columns with
IEEE 754 total order, so pyarrow no longer prunes row groups
on their min/max.
Drop build_diskgraph_wheel's cargo update of time: the staged
source's Cargo.lock already pins 0.3.47.
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
⚠️ Outside diff range comments (1)
Minor · Replace the copyright placeholder in the alloc-stdlib 0.3.0 notice. · THIRD-PARTY.txt:1184
THIRD-PARTY.txt:1184 Minor · Data Integrity & Integration · Quick win
Replace the copyright placeholder in the alloc-stdlib 0.3.0 notice.
The alloc-stdlib 0.3.0 entry in THIRD-PARTY.txt at line 1184 still contains Copyright (c) <year> <owner>.. That entry lists binaries that ship in the distribution, including diskgraph._c.abi3.so and bin/ingest.exe. The shipped notice therefore lacks the copyright attribution.
Take the upstream copyright holder and year from the crate's LICENSE. Correct the source notice data in 3rdparty/notices/inventory.json. Then regenerate the file with python scripts/gen_third_party.py --output THIRD-PARTY.txt, as documented in docs/development/generated-artifacts.md. Do not edit the generated THIRD-PARTY.txt directly.
Files not fully reviewed because their changes were unavailable: 1
3rdparty/notices/inventory.json
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
What
Move every arrow-rs crate and parquet in DiskGraph from 59.3.2 to 60.1. Also remove a stale
cargo updateoftimefromdocker/build_diskgraph_wheel; the lockfile already pins it.Why
parquet 60 brings zstd 0.14, which clears RUSTSEC-2026-0391, -0398, -0403 and -0410.
Behavior change
parquet-rs 60 always marks float and double columns with IEEE 754 total order (apache/arrow-rs#9619), and pyarrow up to 24 ignores min/max statistics on such columns (apache/arrow#50807). The only effect is that a reader filtering on a float column reads every row group instead of skipping some. Kumo never does that: DiskGraph doesn't read float statistics, and our Python code reads these files whole or filters only on ID columns. Values are unchanged.
Change map