Repository navigation
Keep graph visualization from changing the graph or adding notebook exports - #170
Closed
kumo-isaac wants to merge 2 commits into
Closed
kumo-isaac wants to merge 2 commits into
kumo-isaac wants to merge 2 commits into
Conversation
…tebook exports The viewer renders tables without a primary key, but codegen evals showed the agent adding one to an event table (3 of 4 runs) and saving graph.svg from notebooks (16 of 38). State both limits in the visualization skill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kumo-isaac
temporarily deployed
to
gha-kumo-workflow-tests
November 3, 2026 18:34 — with
GitHub Actions
Inactive
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
kumo-isaac
temporarily deployed
to
gha-kumo-workflow-tests
November 4, 2026 21:47 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@devanj08, this is a 4-line follow-up to #154, stacked on
docs/graph-visualization-skills. It fixes two codegen problems the evals found in #154. The router and intake are untouched.What happens and why
The codegen eval (kumo_skill_dev harness, 38 cases scored against reference specs) showed two side effects of the new graph-preview guidance:
primary_key="STATUS_EVENT_ID"onrig_status_events) in 3 of 4 runs on Surface graph visuals in customer agent workflows #154, and in 0 of 4 on its base. The viewer doesn't need it:render()only requires keys on edge destination tables, whichGraphalready enforces.graph.svg(16 of 38), although the SVG export is meant for scripts only.The fix
Four lines in
kumo-graph-visualization/SKILL.md:Validation
Base
fa46bed, #154 head86eccb1, and this PR52b00016, all loaded through the same eval loader. The loader was patched to includekumo-graph-visualization/SKILL.mdin the codegen prompt, because the router tells every train notebook to use it.end_datecase (4 runs)graph.svg34e889459f9c94f094938e3794f094938e37(identical, so intake unchanged)Intake on #154 itself: 82/90 against 80/90 on base (Nemotron judge), with no case regressed and no training request routed to the visualization skill by mistake.
Why the router is not touched: rewording its SVG sentence to "A script, never a notebook, includes…" fixed codegen equally well, but it broke two intake cases where a field is missing.
nov-andvideoamp-missing-positive-interactionasked back 0 of 3 times, against 15 of 16 on base and #154. Putting the change only in the visualization skill, which intake never reads, avoids that.agent-skillstests: 184 passed.Not covered:
Blast radius
Skill guidance only, in one file that the agent reads at codegen time.
Separately, for #154 as a whole: no released kumo-engine build has
Graph.visualize. PyPI1.0.0(2026-10-17) predates #134. Until a release includes it, the preview cell prints "Graph preview unavailable". Details: #154 (comment)🤖 Generated with Claude Code