Skip to content

docs(admin-cli): clarify expected interface JSON fields - #4848

Merged
chet merged 1 commit into
NVIDIA:mainfrom
chet:gh-issue-4847
Aug 12, 2026
Merged

docs(admin-cli): clarify expected interface JSON fields#4848
chet merged 1 commit into
NVIDIA:mainfrom
chet:gh-issue-4847

Conversation

@chet

@chet chet commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Explain the numeric network_segment_type values accepted by the Expected Machine CLI and make patch omission behavior explicit.

This keeps the live --help output as the source for the generated CLI reference.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Verified the updated contract in nico-admin-cli expected-machine add --help and nico-admin-cli expected-machine patch --help. The generated CLI reference remains isolated in the docs-only #4418 PR.

Explain the numeric `network_segment_type` values accepted by the Expected Machine CLI and make patch omission behavior explicit.

This keeps the live `--help` output as the source for the generated CLI reference.

This supports NVIDIA#4847

Signed-off-by: Chet Nichols III <chetn@nvidia.com>
@chet
chet requested a review from a team as a code owner August 11, 2026 23:11
@chet

chet commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai full_review, thanks!

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3a414a8c-7aa2-4f9e-a0d5-56feaa1b8e80

📥 Commits

Reviewing files that changed from the base of the PR and between 0c927ed and e158cac.

📒 Files selected for processing (2)
  • crates/admin-cli/src/expected_machines/add/args.rs
  • crates/admin-cli/src/expected_machines/patch/args.rs

Summary by CodeRabbit

  • Documentation
    • Clarified the --interfaces command-line option help text.
    • Documented that omitting optional interface fields clears their stored values, including the network segment type.

Walkthrough

The PR updates Expected Machine CLI help text. The patch command now documents that omitted optional interface fields, including network_segment_type, are cleared. The add command help text remains unchanged.

Changes

Expected Machine CLI

Layer / File(s) Summary
Clarify interface field omission behavior
crates/admin-cli/src/expected_machines/add/args.rs, crates/admin-cli/src/expected_machines/patch/args.rs
The patch command documents clearing omitted optional interface fields, including network_segment_type. Existing role and IP-allocation rules remain documented. The add command text is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the administrative CLI documentation change for expected interface JSON fields.
Description check ✅ Passed The description accurately covers the numeric network_segment_type values and patch omission behavior described by the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@chet I will perform a complete review of this pull request.

🐇

✅ Action performed

Full review finished.

@pbreton pbreton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chet
chet merged commit 6c92b73 into NVIDIA:main Aug 12, 2026
65 checks passed
@chet
chet deleted the gh-issue-4847 branch August 12, 2026 19:05
srinivasadmurthy pushed a commit to srinivasadmurthy/bare-metal-manager-core that referenced this pull request Aug 13, 2026
Explain the numeric `network_segment_type` values accepted by the
Expected Machine CLI and make patch omission behavior explicit.

This keeps the live `--help` output as the source for the generated CLI
reference.

## Related issues

- NVIDIA#4847
- Documentation companion:
NVIDIA#4151

## Type of Change

- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [x] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes

- [ ] **This PR contains breaking changes**

## Testing

- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [x] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes

Verified the updated contract in `nico-admin-cli expected-machine add
--help` and `nico-admin-cli expected-machine patch --help`. The
generated CLI reference remains isolated in the docs-only NVIDIA#4418 PR.

Signed-off-by: Chet Nichols III <chetn@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants