docs(admin-cli): clarify expected interface JSON fields - #4848
Merged
Conversation
Explain the numeric `network_segment_type` values accepted by the Expected Machine CLI and make patch omission behavior explicit. This keeps the live `--help` output as the source for the generated CLI reference. This supports NVIDIA#4847 Signed-off-by: Chet Nichols III <chetn@nvidia.com>
Contributor
Author
|
@coderabbitai full_review, thanks! |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughThe PR updates Expected Machine CLI help text. The patch command now documents that omitted optional interface fields, including ChangesExpected Machine CLI
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
🐇 ✅ Action performedFull review finished. |
10 tasks
10 tasks
srinivasadmurthy
pushed a commit
to srinivasadmurthy/bare-metal-manager-core
that referenced
this pull request
Aug 13, 2026
Explain the numeric `network_segment_type` values accepted by the Expected Machine CLI and make patch omission behavior explicit. This keeps the live `--help` output as the source for the generated CLI reference. ## Related issues - NVIDIA#4847 - Documentation companion: NVIDIA#4151 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Verified the updated contract in `nico-admin-cli expected-machine add --help` and `nico-admin-cli expected-machine patch --help`. The generated CLI reference remains isolated in the docs-only NVIDIA#4418 PR. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the numeric
network_segment_typevalues accepted by the Expected Machine CLI and make patch omission behavior explicit.This keeps the live
--helpoutput as the source for the generated CLI reference.Related issues
Type of Change
Breaking Changes
Testing
Additional Notes
Verified the updated contract in
nico-admin-cli expected-machine add --helpandnico-admin-cli expected-machine patch --help. The generated CLI reference remains isolated in the docs-only #4418 PR.