Fix devspace build-container-localdev race - #4669
Open
kensimon wants to merge 1 commit into
Open
Conversation
See NVIDIA#3106: If the build container doesn't exist yet, three different builds try to crate it at the same time and only one of them "wins", failing the first build. Fix it by making an explicit before:build step that ensures build-container-localdev exists.
Contributor
Summary by CodeRabbit
WalkthroughThe DevSpace configuration moves the shared ChangesLocal build preparation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
devspace.yaml (1)
49-50: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy liftSerialize the base-image build
The global
before:buildhook is serialized only within one DevSpace invocation. Separatedevspace buildprocesses can both passdocker image inspectbefore either createsbuild-container-localdev.Use an inter-process lock or another mechanism that serializes this build for all three application images.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@devspace.yaml` around lines 49 - 50, Update the before:build workflow around the application image build command to use an inter-process lock or equivalent cross-process serialization, ensuring all three application image builds cannot concurrently pass the base-image check and create build-container-localdev. Preserve the existing Docker build behavior while applying the shared synchronization across separate devspace build invocations.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@devspace.yaml`:
- Around line 49-50: Update the before:build workflow around the application
image build command to use an inter-process lock or equivalent cross-process
serialization, ensuring all three application image builds cannot concurrently
pass the base-image check and create build-container-localdev. Preserve the
existing Docker build behavior while applying the shared synchronization across
separate devspace build invocations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6dc44d98-adf2-4f4e-b1d7-34a7f5429ede
📒 Files selected for processing (1)
devspace.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3106: If the build container doesn't exist yet, three different builds try to crate it at the same time and only one of them "wins", failing the first build.
Fix it by making an explicit before:build step that ensures build-container-localdev exists.
Related issues
#3106
Type of Change
Breaking Changes
Testing
Additional Notes