fix(setup): make core image name configurable - #4667
Open
kirson-git wants to merge 1 commit into
Open
Conversation
Signed-off-by: Erez Kirson <ekirson@nvidia.com>
kirson-git
requested review from
a team,
polarweasel and
shayan1995
as code owners
August 6, 2026 09:25
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the setup workflow with the NICo Core image produced by
make images, while retaining an explicit compatibility override for legacy image names.Related issues
Closes #4666
Type of Change
Breaking Changes
Testing
Validated with:
bash -n helm-prereqs/setup.sh helm-prereqs/preflight.shgit diff --checkmake helpnicoandnvmetal-carbideimage names, plus rejection of a full tagged image pathAdditional Notes
NICO_CORE_IMAGE_NAMEdefaults tonico, matching the local build. Set it tonvmetal-carbidewhen deploying legacy CI or NGC images. Standalone and setup-driven preflight checks resolve and validate the same value.