ci: Build Go binaries per arch target instead of per REST service - #4644
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe workflow runs one matrix job per target platform. Each job builds all listed commands, validates binary output and target metadata, creates a SHA256 manifest, and uploads the target binaries with the manifest. ChangesREST binary build workflow
Estimated code review effort: 3 (Moderate) | ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/rest-build-binaries.yml:
- Around line 111-130: Replace the `expected` count derived from `COMMANDS` with
a separate expected command-name inventory, and compare its exact set against
the names parsed from `COMMANDS` before artifact validation/build or upload
proceeds. Keep the existing per-binary checks around `binaries` and `go version
-m`, but ensure missing, extra, or duplicate declared names cause the workflow
to fail.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2a8c5353-6b54-45de-a271-428624ddf49b
📒 Files selected for processing (1)
.github/workflows/rest-build-binaries.yml
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-08-06 01:56:25 UTC | Commit: c4b1f72 |
|
Just for reference to the wider audience/historical purposes, I had put up #4618 as well, which both has similar intent but in a slightly different way. @thossain-nv and I chatted for a bit on the side about it. First and foremost, CICD discussions come up frequently, but there's always such an outpouring of opinions, then nothing happens because people are at a stalemate. We didn't want that. We wanted progress! So consensus is to start with this approach, get us mileage and collect some data, and then if we want to continue to iterate, we can then possibly adopt the additional structuring that comes with a build manifest and coordination across pipelines, but it's probably not something we'd really need; this PR takes care of most of it, and if we never thought about it again, would live a long and happy existence on its own. Overarching goal is to improve things, and this does that, so lets do it! |
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, we can iterate as needed like another comment said
c4b1f72 to
941c322
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-4644.docs.buildwithfern.com/infra-controller |
|
Thanks @chet for the summary of our discussion. |
Optimize Go binary build CI job by consolidating them per architecture.
Related issues
#4581
Type of Change
Breaking Changes
Testing