Skip to content

ci: Build Go binaries per arch target instead of per REST service - #4644

Merged
thossain-nv merged 2 commits into
NVIDIA:mainfrom
thossain-nv:task/rest-ci-build
Aug 7, 2026
Merged

ci: Build Go binaries per arch target instead of per REST service#4644
thossain-nv merged 2 commits into
NVIDIA:mainfrom
thossain-nv:task/rest-ci-build

Conversation

@thossain-nv

@thossain-nv thossain-nv commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Optimize Go binary build CI job by consolidating them per architecture.

Related issues

#4581

Type of Change

  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • No testing required (docs, internal refactor, etc.)

@thossain-nv
thossain-nv requested a review from chet August 6, 2026 01:52
@thossain-nv
thossain-nv requested a review from a team as a code owner August 6, 2026 01:52
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 08107c96-a712-4989-ab70-5f92b5ef1e64

📥 Commits

Reviewing files that changed from the base of the PR and between 941c322 and c7b4dd4.

📒 Files selected for processing (1)
  • .github/workflows/rest-build-binaries.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/rest-build-binaries.yml

Summary by CodeRabbit

  • Bug Fixes
    • Improved release build reliability across supported target platforms.
    • Builds now run consistently for each target platform and include all required commands.
    • Added validation to confirm every expected binary is created.
    • Added target-specific checksum files to uploaded build artifacts.
    • Consolidated platform build outputs into complete, easier-to-download artifact bundles for simpler downloads and verification.

Walkthrough

The workflow runs one matrix job per target platform. Each job builds all listed commands, validates binary output and target metadata, creates a SHA256 manifest, and uploads the target binaries with the manifest.

Changes

REST binary build workflow

Layer / File(s) Summary
Target matrix and command builds
.github/workflows/rest-build-binaries.yml
The matrix defines three target platforms and a shared command list. Each target job builds every command with its configured GOOS and GOARCH.
Binary validation and artifact publication
.github/workflows/rest-build-binaries.yml
The workflow checks binary presence, target metadata, and binary count. It creates a target-specific SHA256 manifest and uploads all target binaries with the manifest.

Estimated code review effort: 3 (Moderate) | ~15 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes consolidating Go binary builds by architecture target instead of REST service.
Description check ✅ Passed The description directly explains the CI optimization and identifies it as an internal, non-breaking change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/rest-build-binaries.yml:
- Around line 111-130: Replace the `expected` count derived from `COMMANDS` with
a separate expected command-name inventory, and compare its exact set against
the names parsed from `COMMANDS` before artifact validation/build or upload
proceeds. Keep the existing per-binary checks around `binaries` and `go version
-m`, but ensure missing, extra, or duplicate declared names cause the workflow
to fail.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2a8c5353-6b54-45de-a271-428624ddf49b

📥 Commits

Reviewing files that changed from the base of the PR and between 599c38f and c4b1f72.

📒 Files selected for processing (1)
  • .github/workflows/rest-build-binaries.yml

Comment thread .github/workflows/rest-build-binaries.yml Outdated
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-08-06 01:56:25 UTC | Commit: c4b1f72

@chet

chet commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Just for reference to the wider audience/historical purposes, I had put up #4618 as well, which both has similar intent but in a slightly different way.

@thossain-nv and I chatted for a bit on the side about it. First and foremost, CICD discussions come up frequently, but there's always such an outpouring of opinions, then nothing happens because people are at a stalemate. We didn't want that. We wanted progress!

So consensus is to start with this approach, get us mileage and collect some data, and then if we want to continue to iterate, we can then possibly adopt the additional structuring that comes with a build manifest and coordination across pipelines, but it's probably not something we'd really need; this PR takes care of most of it, and if we never thought about it again, would live a long and happy existence on its own.

Overarching goal is to improve things, and this does that, so lets do it!

@nv-dmendoza nv-dmendoza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can iterate as needed like another comment said

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

@thossain-nv

Copy link
Copy Markdown
Contributor Author

Thanks @chet for the summary of our discussion.

@thossain-nv
thossain-nv merged commit 9d296f6 into NVIDIA:main Aug 7, 2026
120 checks passed
@thossain-nv
thossain-nv deleted the task/rest-ci-build branch August 7, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants