ci(rest): Parallelize REST PR CI jobs reduce overall runtime - #4629
Conversation
Summary by CodeRabbit
WalkthroughThe CI workflows now use hosted runners for selected jobs, separate Docker publishing from pull-request image builds, include the pull-request build in required checks, and avoid recursive submodule checkout. ChangesCI workflow updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Sequence Diagram(s)sequenceDiagram
participant prepare
participant build_and_push
participant build_and_push_pr
participant rest_ci_pass
prepare->>build_and_push: Provide preparation outputs
prepare->>build_and_push_pr: Provide preparation outputs
alt Non-pull-request ref
build_and_push->>rest_ci_pass: Report publishing job result
else Pull-request ref
build_and_push_pr->>rest_ci_pass: Report non-publishing build result
end
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-08-05 21:37:34 UTC | Commit: 5eeb68a |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/rest-ci.yml:
- Around line 182-186: Restrict the build-and-push-pr job permissions to only
contents: read, removing packages: write, pull-requests: write, and
security-events: write because the PR path has push_enabled disabled.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 81f0a56f-995e-4040-8e4e-7669c8eb2ceb
📒 Files selected for processing (3)
.github/workflows/rest-build-push-docker.yml.github/workflows/rest-ci.yml.github/workflows/rest-prepare-build-info.yml
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, speeds up the CI
5eeb68a to
6fc3e93
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-4629.docs.buildwithfern.com/infra-controller |
REST CI runs
~14m. Mostly waiting as the Docker images and Go binaries are gated behind the test jobs even though they take less time to build than the tests take to run. This PR unblocks them and moves two trivial jobs off the self-hosted pool, bringing the pipeline to the~7mrange.Related issues
#4572
Type of Change
Breaking Changes
Testing
Additional Notes
push_enabled(hard-coded false)