chore(forms): cover select default value before connect - #241
Merged
Conversation
Adds a unit test for form reset and restore before connectedCallback so getDefaultValue is exercised. Line coverage 97.77% to 100%, branch coverage 88.37% to 97.67%. No public API or behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
coryrylan
approved these changes
Aug 25, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.5.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task: coverage for
projects/forms/src/mixins/select.ts.Why: the selector chose this file as the smallest gap below 90% branch coverage: "1 uncovered lines, 97.77% lines and 88.37% branches, the smallest gap below the 90% threshold".
The uncovered statement was
#getDefaultValue(), which only runs onformResetCallback/formStateRestoreCallbackwhen#initialValueis still unset (beforeconnectedCallback).Measurement
Added one test in the existing
select.test.ts. No other source file changed.Public API
No public API changed. Production
select.tsis untouched. Behavior is unchanged; this is test-only coverage.Left alone
#getDefaultValueor change reset/restore production logic.pnpm run cistill fails threeprojects/stylestypography visuals (text-type ~1%, line-height ~50.5%, override ~33.9%) on this VM; GitHubcionmainis green for the same suite.Validation
projects/forms:lintpass,test287 pass,test:coveragepass,test:lighthousepasstest:types,test:axe,test:ssr,test:visualare not defined for formsgit diff --checkclean; commitlint cleanpnpm run ci: only the pre-existing styles typography visual drift failed