Skip to content

[Epilogue] Fix VisitorRowReduction helper return type - #3627

Open
XFDG wants to merge 1 commit into
NVIDIA:mainfrom
XFDG:fix/visitor-row-reduction-return-3495
Open

XFDG wants to merge 1 commit into
NVIDIA:mainfrom
XFDG:fix/visitor-row-reduction-return-3495

Conversation

@XFDG

@XFDG XFDG commented Sep 13, 2026

Copy link
Copy Markdown

Summary

  • make VisitorRowReduction::Callbacks::reduction return void, matching its side-effect-only implementation and sole call site
  • remove undefined behavior from falling off the end of a non-void device function
  • preserve the existing element-wise register reduction logic unchanged

Testing

  • B200 (SM100a), CUDA 13.1: an explicit instantiation of the helper produces NVCC diagnostic #940-D: missing return statement at end of non-void function on current main
  • B200 (SM100a), CUDA 13.1: the same probe builds and runs with exit code 0 after the fix, with no target return diagnostic

Contribution disclosure

AI assistance was used for repository research, implementation, and running the checks above.

Fixes #3495

@XFDG XFDG changed the title [Epilogue] Fix Visitor78 VisitorRowReduction helper return type [Epilogue] Fix VisitorRowReduction helper return type Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VisitorRowReduction::Callbacks::reduction is declared to return ElementCompute but has no return statement

1 participant