Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the packed metadata E column offset for K slices after the first in three sparse GEMM kernel bodies:
Each offset now divides by kElementsPerElementE, matching the metadata extent and GemmSparseUniversal.
Rationale
The A and B slice offsets are expressed in their respective logical element coordinates. E is different: each stored metadata element describes kElementsPerElementE groups of sparse A values, and its iterator extent already divides by both kSparse and kElementsPerElementE.
The old E offset divided only by kSparse. For split-K slices greater than zero, this started metadata iteration beyond the packed E slice. Predication then suppressed valid metadata loads and the slice accumulated against invalid zero-filled metadata.
Validation
Used the non-universal SparseGemm path from example 15 with serial split-K enabled. Built with CUDA 13.1 and -arch=sm_100a and ran on an NVIDIA B200.
Control:
Before:
After:
This path is distinct from the existing GemmSparseUniversal split-K test coverage.
Fixes #3533