Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the ColumnMajor EllGemm specialization size its serial split-K semaphore workspace from the same transposed problem shape used by initialize().
Add a regression test for both rectangular orientations, covering the previous under-allocation and over-allocation cases.
Rationale
ColumnMajor output is implemented by exchanging M/N and forwarding to a RowMajor underlying operator. initialize() correctly computes its launch grid from (n, m, k), but get_workspace_size() used the original (m, n, k).
For rectangular problems, the two shapes can produce different tile counts. With m=264, n=136, ell_blocksize=32, and four split-K slices, workspace sizing returned 15 semaphore slots while the initialized grid contains 18 output tiles. This left part of the semaphore array outside the allocation/initialization contract.
Using the transposed problem shape in get_workspace happens to match initialize() and the underlying operator for every aspect ratio.
Validation
Compiled the same standalone reproducer before and after this change with CUDA 13.1 and -arch=sm_100a, then ran it on an NVIDIA B200.
Before:
After:
Fixes #3539