Conversation
XFDG
force-pushed
the
fix/conv-filter-pointer-offset-3504
branch
from
September 28, 2026 05:27
d71919e to
bd22204
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix add_pointer_offset byte scaling in five convolution filter tile access iterators:
Add a lightweight convolution threadblock unit test that constructs each iterator and verifies its observable pointer displacement.
Rationale
These iterators store their base pointer as char const*, while add_pointer_offset documents its argument in units of Element. The byte displacement must therefore be:
pointer_offset * sizeof_bits::value / 8
The previous inverted expression multiplied by 8 and divided by the element bit width. For fp16, advancing by 8 elements moved 4 bytes instead of 16; fp32 was off by a factor of 16.
Validation
Built the same host/device CUDA probe before and after the change using CUDA 13.1 and -arch=sm_100a, then ran it on an NVIDIA B200.
Before:
After:
Fixes #3504