Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add runtime shape-divisibility validation when layout composition combines a fully static left-hand layout with a dynamic right-hand tiler.
The existing logical_divide core test now covers both:
Rationale
The composition path already diagnoses fully static incompatibilities at compile time. When the right-hand shape is dynamic, however, new_shape and rest_shape become dynamic and the static assertion cannot run. The fallback runtime assertion was skipped even though each left-hand mode was still statically known, allowing an incompatible divide to silently return a non-size-preserving layout.
Limiting the runtime assertion to a statically known curr_shape closes that mixed static/dynamic gap without changing the intentionally permissive fully dynamic path.
Validation
Compiled the same standalone reproducer before and after this change with CUDA 13.1 and -arch=sm_100a, then ran it on an NVIDIA B200.
Before:
After:
The cluster image does not provide GTest, so the added core regression test is left for the upstream test target to compile and execute.
Fixes #3513