Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lowest()tocutlass::platform::numeric_limits<float>LinearCombinationClamp<float>on both the host and device in the core functional testsProblem
LinearCombinationClampobtains its lower saturation bound fromcutlass::platform::numeric_limits<ElementOutput>::lowest(). The float specialization exposesmax()but notlowest(), so explicitly instantiatingLinearCombinationClampwith a float output fails to compile even though float is part of the class's public template contract.The new member returns
-max(), matching the standard definition of the lowest finite IEEE-754 float while reusing the specialization's existing exactmax()encoding.Validation
Using CUDA 13.1 and
-arch=sm_100aon an NVIDIA B200:numeric_limits<float> has no member lowesthost=2 device=2git diff --checkpassesThe core regression test uses the existing
unary_operatorkernel andHostTensorutilities to exercise both compilation paths.Fixes #3509