Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three
numeric_limitsconstants whose encoded values do not match the represented low-precision types:float_ue8m0_t::lowest():0xfe->0x00in both thestdand CUTLASS platform specializationstfloat32_t::epsilon():0x00001000->0x3a800000(2^-10)half_t::epsilon():0x1800->0x1400(2^-10) in both specializationsThe existing core tests now pin each corrected encoding.
Rationale
float_ue8m0_tis unsigned, so its lowest finite value is also its minimum encoded value,0x00(2^-127), rather than0xfe(2^127). TF32 and FP16 each carry 10 explicit fraction bits fornumeric_limitspurposes, so their machine epsilon is2^-10.Validation
Built the same standalone CUDA probe against current main before and after this change using CUDA 13.1 and
-arch=sm_100a, then ran it on an NVIDIA B200.Before:
lowest()specializations returned0xfeepsilon()returned0x00001000epsilon()specializations returned0x1800on the host and deviceAfter:
failures=0git diff --checkpassesFixes #3508