Add cancellation semantics to decoder - #833
Open
eliotheinrich wants to merge 8 commits into
Open
eliotheinrich wants to merge 8 commits into
eliotheinrich wants to merge 8 commits into
Conversation
eliotheinrich
force-pushed
the
pr-cooperative-cancellation
branch
from
September 16, 2026 22:46
2599c6b to
92ee650
Compare
…for trt_decoder and sliding_window Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
eliotheinrich
force-pushed
the
pr-cooperative-cancellation
branch
from
September 16, 2026 22:51
92ee650 to
a21505d
Compare
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
eliotheinrich
force-pushed
the
pr-cooperative-cancellation
branch
from
September 17, 2026 00:51
b370c45 to
a27907b
Compare
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
eliotheinrich
marked this pull request as ready for review
September 17, 2026 15:21
tlshannon
reviewed
Sep 17, 2026
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
cancellation_sourcecontaining shared cancellation state for ensemble decoders, which can be queried via acancellation_token. This will be used for orchestrating ensembles of decoders under deadlines. Decoders gain an overloadeddecode(syndrome, token)call, allowing them to provide an appropriate behavior for polling the token and aborting early, returning a nullopt. Default behavior is to ignore the token and delegate todecode(syndrome).The trt_decoder inference does not provide an interface for cancellation, but it does pass the cancellation token to the global decoder. The sliding_window decoder does the same.
Self-review checklist
Please confirm each item before requesting review. Check
[x]or strikethrough and explain.
Before requesting review
Scope and size
(if so, an issue has been raised).
Tests
just when it is missing.
EXPECT_*/assertchecks areinsufficient for algorithmic correctness.
Documentation
tracked.
Code style
snake_casevscamelCase) forthe area being modified.
Dependencies
OSRB tickets filed.