[GiGiKoneti]

Short-circuit and folded constants can inherit a synthetic type's module-header location or an operand's definition instead of the expression that produces them. Pass the expression span into constant construction so Line and Full debug modes preserve the expression's file, line and nested inline callers.

Const-bool bindings in entries, functions and methods use the corresponding callee signature. Resolving caller coordinates in a callee scope could otherwise attach the binding to the wrong file/line.

The new constant_source_locations CPU CI target checks deciding false/true constants, a folded expression on a different line from its operands, and all three binding contexts. It verifies exact cross-file caller chains both in the IR and after bytecode serialization.

Validation: all three regressions pass and fail on the earlier compiler; selectively restoring the old folded-expression span fails its dedicated regression. Existing debug/generated-source tests, assembler/GPU/CUDA-GDB checks, formatting and strict Clippy pass on CUDA 13.3. Combined debug validation in #1613 passes all 35 tests. CI and review remain required before merge.

Part of #1475; v0.5.0 tracking: #1606.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[elibol]

Reviewing this against the short-circuit item assigned in #1475. The new test checks a direct || constant and an inlined && constant, including the caller line, which matches that scope.

Before considering those sub-items covered:

• Run the exact-location checks in both Line and Full, and add a helper from another file. Assert the file, subprogram, and complete nested caller chain as well as the expression line, then verify the relevant location survives bytecode serialization. Include both deciding values (false for &&, true for ||).
• The diff also changes the constant-folding call to compile_constant_from_exact_bounds to pass the expression span. Please add a dedicated regression that forces that path (for example, a folded arithmetic expression used by the kernel), checks its original expression location and inline chain, and fails before this change. The current boolean test does not establish the constant-folding item in cuTile: audit generated source locations (optional follow-ups to #1379) #1475. If that change remains, describe both covered items in the PR.
• The shared-builder signature also updates const-bool entry/function/method bindings. Exercise those paths to pin the intended binding/call-site locations, and check compatibility with fix: correct cuTile source locations for generated constants #1385's location fallback rather than relying on it to supply the expression span.

Please record the focused fail-before/pass-after result. Wrapper locations, arrays, reductions, and injected checks remain separate #1475 work; this PR should not close the entire audit or claim to fix backend assertion traps.

[elibol]

/ok to test 64f0ebf

[elibol]

Pushed 64f0ebf4ae61541eb2b2fe9c2ae4cac465a09e12, merging current main and addressing the outstanding test feedback.

Fixed a const-bool attribution issue in the proposed change: function/method bindings resolved a caller expression span inside the callee scope. They now use the callee signature, matching const-array bindings.

The new CPU CI target checks deciding false/true short-circuit constants, a folded expression on a different line from both operands, and entry/function/method const-bool bindings. It covers Line/Full, cross-file nested callers and exact serialized chains. Regressions fail on the earlier compiler; reverting only the folded-expression span also fails its dedicated test.

All three new tests and the existing debug/generated-source suites pass on CUDA 13.3, including assembler/GPU/CUDA-GDB. Strict Clippy for the new target and formatting pass. Combined source-location/debug-mode validation in #1613 passes all 35 tests. Fresh CI is running. This covers the short-circuit/folded-expression/const-bool portion of #1475; tracked in #1606.

[elibol]

Reviewed the current head. The short-circuit and folded-expression changes preserve the originating expression, and const-bool bindings use the callee definition rather than interpreting caller spans in the callee scope. The exact Line/Full and serialized cross-file caller-chain regressions cover the claimed frontend fixes; the combined focused suite also passes on CUDA 13.3. Approving this scope. Backend assertion-trap/coredump attribution remains tracked separately in #1379.

[elibol]

/ok to test 701cf41

[elibol]

Re-reviewed after merging current main and resolving the overlap with #1385. Both independent regression suites are retained, and the compiler diff remains limited to the previously reviewed short-circuit/folded/const-bool origins. All 21 focused constant/debug tests pass on CUDA 13.3, including assembly, GPU execution and live CUDA-GDB; formatting and diff checks pass. Renewing approval for this head.

[elibol]

Renewing approval after the signature-only history rewrite. Every rewritten commit preserves its author and exact tree; the head tree is identical to 701cf41, where all 25 applicable checks passed, including Rust CodeQL and GPU CI. GitHub now verifies all three PR commits. No source or test change was made by signing. The earlier local 21-test assembler/GPU/GDB validation applies unchanged.