cuda.core: reject a mismatched UUID in register() - #2698
Open
fedonman wants to merge 1 commit into
Open
Conversation
MP_register validated the caller's UUID against the resource's own with a bare assert. Assertions are removed under python -O, so an optimized interpreter accepted a mismatched key, registered the resource under it and rewrote the resource's UUID, leaving mr.uuid reporting the new value. Raise ValueError instead, before the registry insertion, so the check holds regardless of interpreter flags. Closes NVIDIA#2697 Signed-off-by: Vyron Vasileiadis <hi@fedonman.com>
Contributor
github-actions
Bot
added
the
cuda.core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MP_registerchecked the caller's UUID against the resource's own with a bareassert, which is removed underpython -O. This raisesValueErrorinstead, before the registry insertion, and adds a regression test over both IPC-enabled resource types.