Add exact-name bitcode library lookup#2302
Conversation
|
@benhg, @leofang: I checked CUDA 12.0–13.3 and NVSHMEM cu12 wheels 3.6.5, 3.7.0, and 3.7.1. All actual bitcode filenames end in |
I could go either way. The argument in favor of looser checking is we may have new formats (e.g. .bc.fatbin or .bc.gz or something), and could use the same function to support .ltoir. The argument against is more risk of bugs |
| return _locate_bitcode_lib(name) | ||
|
|
||
|
|
||
| def locate_bitcode_lib_by_name(name: str, filename: str) -> LocatedBitcodeLib: |
There was a problem hiding this comment.
name and filename are quite confusing IMHO. Is name the directory name that contains the bitcode library?
There was a problem hiding this comment.
Name is the library name (e.g. "nvshmem"). Filename is the bitcode filename (e.g. "libnvshmem_device.bc")
Description
Addresses new design of #2200.