Skip to content

docs: fix NVML wording#2301

Merged
mdboom merged 2 commits into
NVIDIA:mainfrom
uday1o1:main
Jul 7, 2026
Merged

docs: fix NVML wording#2301
mdboom merged 2 commits into
NVIDIA:mainfrom
uday1o1:main

Conversation

@uday1o1

@uday1o1 uday1o1 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the incorrect NVML expansion and clarifies the cuda.core.system cuda-bindings version requirement.

This updates:

  • incorrect NVML references to NVIDIA Management Library (NVML)
  • cuda.core.system support wording for CUDA 12.x and CUDA 13.x cuda-bindings versions
  • matching docs, stubs, runtime message, and test skip text

@copy-pr-bot

copy-pr-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module Needs-Restricted-Paths-Review labels Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Needs-Restricted-Paths-Review was assigned by CI: Restricted Paths Guard.

For details, open this workflow run and click Summary.

For external contributors: thank you for your interest in improving CUDA Python. The cuda_bindings/ package is distributed under the NVIDIA Software License, which does not allow us to accept external contributions to files under cuda_bindings/ in this repository.

Please close this PR. If your changes also include updates outside cuda_bindings/, please open a new PR containing only those changes so we can review them separately under the applicable license.

If you are an NVIDIA employee and believe this label was applied in error, no action is needed; a maintainer will review and remove the label if appropriate.

@uday1o1 uday1o1 changed the title docs: configure Context7 and fix package wording docs: configure Context7 and fix NVML wording Jul 5, 2026

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NVML-related changes all look great.

The context7.json changes seem unrelated (and I don't feel qualified to review them). Can you separate them out into their own PR?

@uday1o1 uday1o1 changed the title docs: configure Context7 and fix NVML wording docs: fix NVML wording Jul 6, 2026
@uday1o1

uday1o1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, agreed. I split the Context7 configuration into #2303 and kept this PR scoped to the NVML wording/version clarification.

@uday1o1 uday1o1 marked this pull request as ready for review July 6, 2026 19:52
@mdboom mdboom enabled auto-merge (squash) July 6, 2026 21:44
@mdboom

mdboom commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test 6bd122a

@github-actions

This comment has been minimized.

@mdboom mdboom merged commit ec4af50 into NVIDIA:main Jul 7, 2026
103 of 104 checks passed
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang added documentation Improvements or additions to documentation and removed cuda.bindings Everything related to the cuda.bindings module Needs-Restricted-Paths-Review labels Jul 7, 2026
@leofang leofang added this to the cuda.core v1.1.0 milestone Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants