Conversation
phu0ngng
requested review from
jberchtold-nvidia and
ptrendx
as code owners
September 15, 2026 19:51
Contributor
|
| def test_raises_when_borrowed_comm_unavailable(self): | ||
| import transformer_engine.jax.ep as ep_mod | ||
|
|
||
| with mock.patch.object(ep_mod.jax, "local_device_count", return_value=2), mock.patch.object( |
Collaborator
There was a problem hiding this comment.
I like this mocking of tests to test our error paths too!
jberchtold-nvidia
previously approved these changes
Sep 16, 2026
jberchtold-nvidia
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Thanks!
Once CI passes, all good to merge from my side
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
phu0ngng
force-pushed
the
ep_jax_single_process_backup
branch
from
September 18, 2026 02:17
26bba3f to
901b455
Compare
Collaborator
Author
|
/te-ci L1 JAX |
jberchtold-nvidia
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support single-process, multi-device JAX EP using XLA-borrowed NCCL communicators.
Type of change
Changes
Testing
Checklist: