Repository navigation
fix(ci): enable OTLP export only when a collector is requested - #5348
Merged
Merged
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-5348.docs.buildwithfern.com/openshell |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. configuration — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
TaylorMutch
reviewed
Nov 6, 2026
Kubernetes E2E layered ci/values-skaffold.yaml, which pointed the gateway at the openshell-collector service that only the local k3d workflow installs. Kind lanes logged a BatchSpanProcessor.ExportError every batch. The local gateway tasks probed 127.0.0.1:4317 instead, and the gateway task configured the endpoint unconditionally. Move the collector endpoint into ci/values-local-tracing.yaml, layered only by skaffold.yaml, and have every local gateway task enable OTLP export only when OPENSHELL_DEV_OTLP_ENDPOINT is set. Closes #5347 Refs #3767 Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
fix/5347-otlp-export-opt-in/krishicks
branch
from
November 6, 2026 20:57
77b18b0 to
6bada4c
Compare
TaylorMutch
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kubernetes CI lanes pointed the gateway's OTLP export at a collector that only the local k3s workflow installs, so every kind run logged a
BatchSpanProcessor.ExportErrorper batch. OTLP export is now opt-in everywhere: the Skaffold workflow layers a separate tracing values file, and the local gateway tasks export only whenOPENSHELL_DEV_OTLP_ENDPOINTis set.Related Issue
Closes #5347
Refs #3767
Changes
ci/values-skaffold.yamlinto a newci/values-local-tracing.yaml, whichskaffold.yamllayers. The Kubernetes E2E harness keeps layering onlyvalues-skaffold.yaml, so its lanes render no OTLP endpoint.127.0.0.1:4317probe ingateway:docker,gateway:podman, andgateway:vmwith a sharedappend_dev_otlp_confighelper that readsOPENSHELL_DEV_OTLP_ENDPOINT.gatewayuses the same helper instead of always configuring the endpoint.helm-dev-environmentanddebug-openshell-clusterskills, and the VM driver README.Testing
helm templatewith onlyvalues-skaffold.yamlrenders no OTLP configuration. Withvalues-local-tracing.yamllayered, it renders the same OTLP configuration as before.shellcheck -xon the changed task scripts reports no new findings.No Rust or Cargo files changed.
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Checklist