Repository navigation
fix(cli): report scheduling failures in provisioning timeouts #5344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -576,9 +576,17 @@ pub fn print_sandbox_header( | |||||||||||||||||
| pub fn ready_false_condition_message( | ||||||||||||||||||
| status: Option<&openshell_core::proto::SandboxStatus>, | ||||||||||||||||||
| ) -> Option<String> { | ||||||||||||||||||
| let condition = status?.conditions.iter().find(|condition| { | ||||||||||||||||||
| condition.r#type == "Ready" && condition.status.eq_ignore_ascii_case("false") | ||||||||||||||||||
| })?; | ||||||||||||||||||
| let conditions = &status?.conditions; | ||||||||||||||||||
| let condition = conditions | ||||||||||||||||||
| .iter() | ||||||||||||||||||
| .find(|condition| { | ||||||||||||||||||
| condition.r#type == "PodScheduled" && condition.status.eq_ignore_ascii_case("false") | ||||||||||||||||||
| }) | ||||||||||||||||||
|
Comment on lines
+582
to
+584
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor: A
Suggested change
A regression test with an empty |
||||||||||||||||||
| .or_else(|| { | ||||||||||||||||||
| conditions.iter().find(|condition| { | ||||||||||||||||||
| condition.r#type == "Ready" && condition.status.eq_ignore_ascii_case("false") | ||||||||||||||||||
| }) | ||||||||||||||||||
| })?; | ||||||||||||||||||
|
|
||||||||||||||||||
| if condition.message.is_empty() { | ||||||||||||||||||
| if condition.reason.is_empty() { | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: With the PodScheduled preference in place, the name
ready_false_condition_messageno longer describes what the function does, andlifecycle_phase_error(run.rs:4245) picks up the new precedence on start/stop/resume error paths, outside the provisioning-timeout scope of #5230 and uncovered by the new tests. A rename (sayprovisioning_blocker_message) or a short doc comment on the precedence, plus either a test or a deliberate note for the lifecycle path, would keep the next reader from tripping over it.