Repository navigation
feat(compute)!: check allowed service ports before creating sandboxes or forwards - #5116
Open
shiju-nv wants to merge 3 commits into
Conversation
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. rust-sdk — No explicit risk acceptance foundPreviously complete Rust creation-spec and raw-message literals now require new
2. state — No explicit risk acceptance foundExisting sandboxes without
Review details
Advisory review; publication gates are unchanged. |
|
Label |
shiju-nv
force-pushed
the
feat/5110-service-port-admission/shiju-nv
branch
2 times, most recently
from
November 2, 2026 16:59
0267aa7 to
717c9c6
Compare
shiju-nv
changed the base branch from
main
to
fix/stopped-driver-watch-fence-c92/shiju-nv
November 2, 2026 16:59
A requested service port should be rejected before provisioning a sandbox or opening a local forwarding listener when the driver cannot admit it. This checks create, exposure and forwarding requests against a retained driver admission record, and shows whether the target uses isolated or operator-approved shared-host loopback. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
fix/stopped-driver-watch-fence-c92/shiju-nv
branch
from
November 3, 2026 11:45
d104104 to
760396e
Compare
shiju-nv
force-pushed
the
feat/5110-service-port-admission/shiju-nv
branch
from
November 3, 2026 11:47
717c9c6 to
a8d2d7f
Compare
2 of 15 tasks
Signed-off-by: Shiju <shiju@nvidia.com>
get.k3s.io serves the latest install.sh from k3s master, so the pinned checksum broke when upstream changed the script. Download install.sh from the release tag matching k3s_version instead and pin its checksum. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com> Signed-off-by: Shiju <shiju@nvidia.com>
github-actions
Bot
requested review from
FrostGod,
TaylorMutch,
alangou,
johntmyers,
pimlock and
russellb
November 4, 2026 17:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check requested service ports against the driver's approved ports before creating a sandbox or opening a local forwarding listener. Keep enforcing the saved ports on gateway routes, and show whether the target uses isolated loopback or shared host loopback that the operator explicitly allowed.
Related Issue
Closes #5110. Part of #5114. Coordinates with service-exposure issue #4310; merged RFC #4267 provides design context.
Depends on #5204. Review this layer against
fix/stopped-driver-watch-fence-c92/shiju-nv, whose current head is 760396e8.Land #5204 first. Then replay only this PR's changes onto the resulting
mainand retarget this existing PR.Changes
Release Notes
Source-breaking API addition for the next minor release only. Complete raw Rust messages need defaults for the new port and admission fields. Upgrade gateway writers together. A legacy driver can omit admission; missing evidence from a negotiated modern driver rejects forwarding until the sandbox is recreated with admitted ports. Maintainers must seed and qualify the minor train before landing; do not merge or backport this into the active patch train.
Testing
Focused verification is reused for the unchanged feature logic and the independently reviewed shared lifecycle correction. Hosted Core E2E passed on this PR's current source. This does not claim installed native-backend qualification.
Checklist