Repository navigation
Conversation
The agent launcher applied manifest settings with `settings set --global`, so every gator launch switched proposal_approval_mode to auto for the whole gateway. Apply them to the launched sandbox after creation instead. If a gateway-global value already manages a key, warn and leave it in effect. Related to NVIDIA#3469. Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. configuration — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
5 of 6 tasks
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent launcher applied manifest settings with
openshell settings set --global, so launching gator switchedproposal_approval_modetoautofor every sandbox on the gateway. This applies manifest settings to the launched sandbox only.Related Issue
Related to #3469. This PR doesn't close the issue; which PR closes it is still to be decided.
Changes
scripts/agents/run.sh: removes the gateway-globalsettings set --globalloop. After the sandbox is created, runsopenshell settings set <sandbox> <key> <value>for each manifest setting. If a gateway-global value already manages a key, it warns and leaves that value in effect. The launcher never writes global settings.scripts/agents/README.mdandscripts/agents/gator/README.md: describe settings as sandbox-scoped, with the updated launch order.Release Notes
Testing
bash -nandshellcheckon the changed scriptsscripts/agents/supervisor_test.shpassesopenshell settings get <sandbox>reportsagent_policy_proposals_enabledandproposal_approval_modeat sandbox scope, and gateway-global settings are unchangedscripts/agents/run_test.shis added by feat(agents): support Kubernetes Gators with reusable tooling images #4744; that branch carries the matching test change)Checklist