Repository navigation
test(server): keep relays queued during session setup behind SessionAccepted - #4689
Merged
FrostGod merged 1 commit intoNov 3, 2026
Conversation
7 tasks
|
This pull request has had no activity for 14 days and is now marked stale. |
github-actions
Bot
added
the
state:stale
…ccepted The supervisor drops a session whose first frame is not SessionAccepted, and the gateway registers a session before it acknowledges it. NVIDIA#4320 fixed the ordering by routing registry traffic through a private channel whose forwarder starts only after the ack is queued, but nothing tested it. The new tests pause setup in its endpoint-status reset, open a relay on the registered but unacknowledged session, and check that the stream yields SessionAccepted and then the queued RelayOpen, in both poll and push mode. With the test harness ported, the poll test fails on the code before NVIDIA#4320. Closes NVIDIA#4687 Signed-off-by: Emilien Macchi <emacchi@redhat.com>
EmilienM
force-pushed
the
test/4687-session-accepted-before-relay/EmilienM
branch
from
November 2, 2026 20:46
b3b0158 to
91b43ec
Compare
FrostGod
self-requested a review
November 3, 2026 06:45
github-actions
Bot
removed
the
state:stale
Collaborator
|
/ok to test 91b43ec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for the session setup race where a
RelayOpencould reach the supervisor beforeSessionAcceptedand make it drop the session. #4320 fixed the ordering when it reworked session setup; these tests keep it fixed.Related Issue
Closes #4687
Part of #3528
Changes
crates/openshell-server/src/supervisor_session.rs, one per config delivery mode (poll and push). Each holds the sandbox mutation guard so setup stops after registration, opens a relay on the session before it's acknowledged, then checks that the stream yieldsSessionAcceptedand then the queuedRelayOpen.Testing
cargo test -p openshell-server --features test-supportpasses (2364 tests), and the two new tests passed 20 repeated runs.RelayOpenas the first frame. Push mode didn't exist there.mise run pre-commitpasses.Checklist