Repository navigation
Conversation
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 2, 2026 21:43
|
This pull request has had no activity for 14 days and is now marked stale. |
github-actions
Bot
added
the
state:stale
13 tasks done
|
Label |
Retain typed local deadline and remote failure causes through HTTP hook diagnostics and request handling. Track local upstream write progress through the existing live writer, including partial failures. Preserve response selection, diagnostic text and request retries. Refs #4144 Build on PR #4359. Caller and event exposure remains with the companion tracing work. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
fix/middleware-request-failure-causes-20261002
branch
from
November 2, 2026 14:46
9a62429 to
bd0b5ba
Compare
shiju-nv
changed the base branch from
feat/2431-streaming-request-middleware/pimlock
to
feat/2431-http-middleware-protocol-2/pimlock
November 2, 2026 14:52
|
🌿 Preview your docs: https://nvidia-preview-pr-4145.docs.buildwithfern.com/openshell |
Collaborator
Author
|
/ok to test bd0b5ba |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTP request middleware retains fixed failure categories separately from diagnostic messages and explicit service denials. Live forwarding also records when upstream writing starts, including a write that fails after partial progress.
This adds the internal cause and delivery primitives. Exposing them in every caller result and serialized event remains with the companion tracing work.
Related Issue
Part of #4144. Stacked on #4359.
Land #4359 first. After its squash merge, replay only this layer onto main and verify the resulting diff.
Changes
Release Notes
Middleware retains structured failure attribution and local delivery progress for downstream observation.
Testing
Eight focused middleware tests, three focused network tests and scoped Clippy for both packages' library and test targets pass. Removing capacity classification fails the regression with InvalidResult versus Capacity; dropping the request-level cause fails with None versus RequestBodyTimeout. Formatting, SPDX and independent source review pass.
The focused tests do not run the complete live relay or real whole-body and idle expiry. E2E coverage is requested with
test:e2e; no final-head E2E pass is claimed yet.Checklist