fix(supervisor-network): warn on unsupported L7 access presets#2177
Open
lunarwhite wants to merge 1 commit into
Open
fix(supervisor-network): warn on unsupported L7 access presets#2177lunarwhite wants to merge 1 commit into
lunarwhite wants to merge 1 commit into
Conversation
Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emit a visible warning when an L7 endpoint uses an unsupported
accesspreset (e.g.access: allow) during proxy-side preset expansion. Previously these values were silently ignored, leaving endpoints with no expandedrulesand no diagnostic when traffic was denied.Policy load and deny behavior are unchanged. This is observability only.
Related Issue
Closes #2008
Related: #2158 (invalid
access: allowreportspolicy_denied; this PR adds the missing load-time warning but does not fix incomplete policy shape)Changes
expand_access_presetsfor unsupportedaccessvalues (read-only,read-write, andfullremain supported)access_preset_ruleshelper to centralize preset expansion logicConfigStateChangeBuilderin both OPA policy-load paths (from_proto_with_pid,preprocess_yaml_data), matching existing L7 validation warning plumbingaccess: allow(warning emitted, rules not expanded)warnings.is_empty()on existing supported-preset expansion testsTesting
mise run pre-commitpassesChecklist