[6648996] Fix NVFP4 ONNX packed-weight scale rounding - #2243
Draft
ajrasane wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Codex <codex@openai.com> Signed-off-by: ajrasane <131806219+ajrasane@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
=======================================
Coverage 79.01% 79.01%
=======================================
Files 523 523
Lines 60695 60705 +10
=======================================
+ Hits 47960 47969 +9
- Misses 12735 12736 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
This PR updates
nvfp4_exporter.pyso NVFP4 ONNX weight compression quantizes FP4 weights with the same FP8-rounded per-block scales serialized in the exported graph. It alignsquant_utils.pyscale arithmetic with eager ModelOpt's FP32 operation ordering and applies the same behavior to the deprecatedfp4qdq_to_2dqcompatibility path inqdq_utils.py.test_onnx_export_cpu.pyadds regression coverage comparing exported FP8 scale bytes and packed FP4 weights againstNVFP4QTensorat FP8-rounding, per-tensor arithmetic, and per-block arithmetic boundaries.CHANGELOG.rstdocuments the fix.Usage
Testing
Ran:
CUDA_VISIBLE_DEVICES="" python -m pytest -q \ tests/unit/torch/quantization/test_onnx_export_cpu.py \ tests/unit/torch/quantization/test_nvfp4_tensor.py \ tests/unit/onnx/quantization/test_qdq_utils.py \ tests/unit/onnx/quantization/test_quant_utils.pyAll 89 tests passed. All applicable pre-commit hooks passed. Additionally verified exact FP8-scale and packed-FP4 parity against eager quantization for 8,000 randomized tensors.
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/A