-
Notifications
You must be signed in to change notification settings - Fork 554
[ONNX] Add quantization sensitivity ranking + exclusion picker #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gcunhase
wants to merge
8
commits into
NVIDIA:main
Choose a base branch
from
gcunhase:dev/gcunhasergio/onnx_sensitivity_scan_verified
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d92db3e
onnx: add sensitivity primitive with exclusion picker for per-op-type…
gcunhase f407d04
picker: add block-aware exclusion via optional blocks + block_agg args
gcunhase 449e556
picker/docs: simplify docstrings; swap ViT block-picker example to ma…
gcunhase 2e3bb2a
style: apply ruff auto-fix + format across sensitivity module
gcunhase 64335e0
docs/picker/tests: post-review simplifications across the sensitivity…
gcunhase 5656505
changelog: move sensitivity entry to end of the Quantization section
gcunhase a63acde
test: fix IndexError in test_nodes_to_quantize (graph-input probe + b…
gcunhase 956bd85
test: bump 2-Conv test weights to 16 channels to clear small-Conv aut…
gcunhase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -407,4 +407,5 @@ def get_activation_ops(): | |
| "Softsign", | ||
| "Swish", | ||
| "HardSwish", | ||
| "Gelu", | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """ONNX quantization sensitivity: rank quantizable targets by per-target Q/DQ drift.""" | ||
|
|
||
| from modelopt.onnx.quantization.sensitivity.picker import suggest_exclusion, summarize_exclusion | ||
| from modelopt.onnx.quantization.sensitivity.score import ( | ||
| CalibrationSource, | ||
| Granularity, | ||
| Metric, | ||
| score, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "CalibrationSource", | ||
| "Granularity", | ||
| "Metric", | ||
| "score", | ||
| "suggest_exclusion", | ||
| "summarize_exclusion", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a pure addition.
get_activation_ops()is consumed byQDQAutotunerBase.get_ort_quantization_config()(modelopt/onnx/quantization/autotune/autotuner_base.py) to buildop_types_needing_output_quant, so addingGeluchanges autotune's Q/DQ placement for any model containingGelu. That's a behavior change to a shipped feature with no test and no mention in the PR body (the body instead describes aTopKaddition tois_fusible_reduction_op, which is already onmain).Please either (a) call this out in the PR body/CHANGELOG and add an autotune-side test asserting the new
op_types_needing_output_quantbehavior, or (b) keep the sensitivity scope local — e.g. addGeluto_default_op_types_scopeinscore.pyinstead of mutating the shared helper.