[4/n] Add joint mask reuse topology selection - #2237
Draft
kaix-nv wants to merge 1 commit into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
kaix-nv
force-pushed
the
kaix/mask-reuse-03-topology-selection
branch
from
August 25, 2026 06:01
0f160c9 to
42dba0d
Compare
Signed-off-by: Kai Xu <kaix@nvidia.com>
kaix-nv
force-pushed
the
kaix/mask-reuse-03-topology-selection
branch
from
August 25, 2026 06:35
42dba0d to
0eba007
Compare
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kaix/mask-reuse-02-vllm-capture #2237 +/- ##
===================================================================
+ Coverage 79.01% 79.12% +0.10%
===================================================================
Files 530 531 +1
Lines 63702 64425 +723
===================================================================
+ Hits 50333 50974 +641
- Misses 13369 13451 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new feature
Adds the third mask-reuse sub-PR: development-only joint discovery of anchor layers, consumer-to-anchor assignments, per-head donor maps, exact fallbacks, target sparsity, and the model-wide BMM1 skip objective. Held-out captures evaluate the frozen topology and cannot retune it.
This PR is stacked on #2236.
Usage
Testing
[0, 2], nearest assignments, head maps{"1": [0, 0], "3": [0, 0]}, and empty fallback sets.kaix/mask-reuse-calib@3b0d268eabyte-for-byte.pre-commit run --files ...: passed.Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/A — no copied code or new dependency.Additional Information
Stack 3 of 3. Base PR: #2236. The selected artifact remains
topology_candidate_only; promotion is deliberately outside this PR.