Skip to content

Harden C++ temporary path handling - #1388

Draft
fvaloppi-nv wants to merge 1 commit into
mainfrom
codex/harden-public-temp-paths-cpp
Draft

fvaloppi-nv wants to merge 1 commit into
mainfrom
codex/harden-public-temp-paths-cpp

Conversation

@fvaloppi-nv

Copy link
Copy Markdown
Contributor

Summary

  • use an atomically restrictive POSIX directory helper for local C++ log files
  • keep the helper private to the logging component and cover its permission and symlink policy directly
  • stop advertising Vive collections when a private runtime path cannot be established
  • place predictable C++ test artifacts below atomically created owner-only directories

Platform scope

  • this PR changes POSIX behavior only
  • Windows keeps its existing per-user temporary-directory and inherited-ACL behavior
  • the POSIX helper is excluded from Windows builds at the CMake boundary

std::filesystem does not expose POSIX ownership, sticky-bit, or no-follow checks. The policy therefore lives in one small testable helper rather than being repeated in sink setup.

Validation

  • SKIP=check-copyright-year pre-commit run --all-files
  • clang-format 14 verification on every touched C++/HPP file
  • 3 focused helper test cases with 14 assertions
  • standalone warning-clean compilation of the helper with C++20

Companion change

PR #1387 contains the Python-only half. Each PR is independently safe, but merging both keeps the Python and C++ logging implementations aligned.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: fvaloppi-nv <fvaloppi@nvidia.com>

This branch was successfully deployed

1 active deployment
dev — ac0c7660 Deployed Oct 28, 2026 by fvaloppi-nv via publish-wheel #6178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants