fix: correct return type annotation of get_nsys_entrypoint#568
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
get_nsys_entrypoint returns a tuple (nsys, ), but its annotation was str. Update the annotation to tuple[str, str] to match the implementation and callers that unpack the result. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
get_nsys_entrypointreturns a tuple("nsys", ""), but its annotation wasstr. This mismatched the implementation and callers that unpack the result.Fix
Update the return type annotation to
tuple[str, str].Test
The existing
TestExecutor::test_get_nsys_entrypointalready asserts the tuple return value.Verification
uv run pytest test/core/execution/test_base.py::TestExecutor::test_get_nsys_entrypoint -vpasses.uv run --group lint ruff check ...andruff format --check ...pass.