fix: replace deprecated ast.* literal types with ast.Constant#567
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix: replace deprecated ast.* literal types with ast.Constant#567andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
ast.Num, ast.Str, ast.Bytes, ast.NameConstant, and ast.Ellipsis are deprecated and removed in Python 3.14. ast.Constant has been the canonical representation since Python 3.8. Adds regression tests verifying PythonicParser treats literal constants as safe. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ast.Num,ast.Str,ast.Bytes,ast.NameConstant, andast.Ellipsisare deprecated and removed in Python 3.14.ast.Constanthas been the canonical representation since Python 3.8.Fix
Replace the deprecated type checks in
nemo_run/cli/lazy.pyandnemo_run/cli/cli_parser.pywithast.Constant.Test
Added
test/cli/test_ast_constants.py::TestPythonicParserLiteralSafety, which verifiesPythonicParser._contains_unsafe_operationstreats literal constants (int, str, bytes, True, None, Ellipsis) as safe.Verification
uv run pytest test/cli/test_ast_constants.py -vpasses.uv run --group lint ruff check ...andruff format --check ...pass.