fix: preserve falsy primitive args in Config/Partial binding#566
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix: preserve falsy primitive args in Config/Partial binding#566andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
_construct_args used to decide whether to copy a keyword argument, which treated 0, False, and '' as missing. Use so legitimate falsy values are preserved during binding. Adds a regression test verifying that 0, False, and empty string args survive Partial construction and build. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
_construct_argsusedif arg:to decide whether to copy a keyword argument, which treated0,False, and""as missing.Fix
Use
if arg is not None:so legitimate falsy values are preserved during binding.Test
Added
TestPartial::test_falsy_primitive_args_are_preserved, which verifies that0,False, and empty-string args surviverun.Partialconstruction andfdl.build.Verification
uv run pytest test/test_config.py::TestPartial::test_falsy_primitive_args_are_preserved -vpasses.uv run --group lint ruff check nemo_run/config.py test/test_config.pyandruff format --check ...pass.