chore(kit): take 0.2.2, which widens what a safe run promises not to invoke - #19
Merged
Conversation
…invoke `forbidden_in_safe_conformance` was the one hand-written literal in a kit whose every other closed set is derived from the protocol source. It listed `apply-operation` and `launch`, while `pure_commands` derives from the read commands and lists four — so the two lists did not partition the seven, and the command left out of both was `recover-operation`, which mutates. The behaviour was never wrong: the consumer's runner never invoked it. The promise was, and a provider reading the kit to learn what a safe run might call was told a mutating command was fair game. Nothing here changes. This build reads `pure_commands`, not the forbidden set, and a wider forbidden set only removes a call that was never made. `manifest.json` moves too, by one line: `kit_version` 0.2.1 -> 0.2.2, as a label that tracks bytes must. Only `conformance-cases.json` changed in content. Aggregate `sha256:24609284…` -> `sha256:f6e4682d…`, verified against the kit's own `SHA256SUMS` before being read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(kit): take 0.2.2, which widens what a safe run promises not to invoke
forbidden_in_safe_conformancewas the one hand-written literal in a kit whoseevery other closed set is derived from the protocol source. It listed
apply-operationandlaunch, whilepure_commandsderives from the readcommands and lists four — so the two lists did not partition the seven, and the
command left out of both was
recover-operation, which mutates.The behaviour was never wrong: the consumer's runner never invoked it. The
promise was, and a provider reading the kit to learn what a safe run might call
was told a mutating command was fair game.
Nothing here changes. This build reads
pure_commands, not the forbidden set,and a wider forbidden set only removes a call that was never made.
manifest.jsonmoves too, by one line:kit_version0.2.1 -> 0.2.2, as a labelthat tracks bytes must. Only
conformance-cases.jsonchanged in content.Aggregate
sha256:24609284…->sha256:f6e4682d…, verified against the kit'sown
SHA256SUMSbefore being read.Rendered from
NDDev-it-com/setup-systems@3fd4439.https://claude.ai/code/session_011eFMKoUdWcc7Aw9vtMxH2A