feat(security): scan the engine, which has never been scanned - #25
Merged
Conversation
This repository has no code scanning. Not stale scanning, not partial —
`GET /code-scanning/analyses` returns `no analysis found`, and default setup is
`not-configured`. Go is 97% of the tree: the compiler, the projection engine,
the release builder, the trust and provenance code that every other repository
in the estate depends on to be correct.
It is not alone. Across the six public modules:
github-device-sync Go 97% nothing
github-actions Go 95% nothing
ci-workflows Python 98% actions, python
cd-workflows Python 75% nothing
macos-ubuntu-bootstrap Python 62% actions only
agent-runtime Go 100% nothing
Four of six have never been scanned, and they are the whole Go control plane.
The republication carried the code across and left the scanning behind; nothing
failed, because nothing was watching.
Advanced setup rather than default setup, so the caller is pinned, reviewable in
a diff, and says which runner it uses. Pinned to `0.1.4` at the commit that tag
actually resolves to — see NDDev-OpenNetwork/ci-workflows#45 for why that is
worth stating: the estate's twelve other call sites all claim a version `0.13.3`
that has never existed, on an untagged commit from before the first release.
Left OUT of `required_contexts` on purpose. A check that has never produced a
green run should not gate merges on the pull request that introduces it; make it
required once it has passed on `main`.
Verified with the repository's own commands: `scripts/validate_shell.sh` PASS
(8 scripts), `go vet ./...` clean, `go build -trimpath ./core/cmd/gds` ok,
`go test ./...` all packages ok. actionlint 1.7.12 clean.
Also confirmed this does not trip #24: `.github` is not in
`developmentBundleSourcePaths`, and `gds context` on the branch reports no
`GDS_CONTEXT_POLICY_SOURCE_DIGEST_MISMATCH`.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository has no code scanning. Not stale, not partial —
GET /code-scanning/analysesreturnsno analysis foundand default setup isnot-configured. Go is 97% of the tree: the compiler, the projection engine, the release builder, and the trust and provenance code every other repository in the estate relies on to be correct.It is not alone
Four of six have never been scanned, and they are the entire Go control plane. The republication carried the code to the new organisation and left the scanning behind. Nothing failed, because nothing was watching — the same shape as the archived-lineage findings in #22, #23 and macos-ubuntu-bootstrap#7.
Secret scanning and push protection were also
disabledon all six; both are free for public repositories and are now on.The change
Advanced setup, not default setup: the caller is pinned, reviewable in a diff, and names its runner.
languages: '["go","actions"]'withautobuild: true— the reusable sets Go up fromgo.modwhen the language isgo.Pinned to
0.1.4at the commit that tag actually resolves to. Worth stating because the estate's twelve other call sites pin an untagged 2026-08-15 commit while claiming version0.13.3, which has never existed — NDDev-OpenNetwork/ci-workflows#45.Deliberately left out of
required_contexts. A check that has never produced a green run should not gate merges on the pull request introducing it. Promote it once it has passed onmain.Verification
The repository's own commands:
scripts/validate_shell.sh→ PASS, 8 scripts, shellcheck 0.11.0go vet ./...→ cleango build -trimpath ./core/cmd/gds→ okgo test ./...→ every package okAnd confirmed this does not trip #24:
.githubis not indevelopmentBundleSourcePaths, andgds contexton this branch reports noGDS_CONTEXT_POLICY_SOURCE_DIGEST_MISMATCH— only the pre-existingGDS_CONTEXT_ESTATE_NOT_REGISTERED.Expect first-run findings. That is the point.