Skip to content

fix(admission): require explicit resource overcommit - #185

Merged
rldyourmnd merged 3 commits into
mainfrom
fix/explicit-resource-reservations
Aug 25, 2026
Merged

fix(admission): require explicit resource overcommit#185
rldyourmnd merged 3 commits into
mainfrom
fix/explicit-resource-reservations

Conversation

@rldyourmnd

Copy link
Copy Markdown
Contributor

Summary

  • default undeclared CPU and memory reservations to the pool hard limits
  • remove the implicit global memory-size overcommit table
  • preserve smaller reservations only when a pool declares them explicitly
  • make per-member placement account full limits by default
  • update the portable queue example and regression coverage

Root cause

Private platform pools declared no reservation, so EffectiveReservation silently converted 4 GiB workers to 2.5 GiB and 6 GiB workers to 2 GiB. Queue and placement therefore admitted materially more memory than the reviewed pool contracts while natural Java, Node, CodeQL, and image jobs produced repeated host OOM.

Validation

  • red regression test observed against the implicit table
  • make verify

Partial fix for #183; live rollout and natural no-OOM acceptance remain private-estate work.

@rldyourmnd
rldyourmnd merged commit 69fb405 into main Aug 25, 2026
10 checks passed
@rldyourmnd
rldyourmnd deleted the fix/explicit-resource-reservations branch August 25, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant