Secondary certificate refresh - #2591
Open
A-Wheeto wants to merge 24 commits into
Open
Conversation
Duplicate each activity with a -secondary slug and attach the duplicates to two new single-activity groupings, so completion is tracked independently per programme. ENG-1532
ENG-1532 ENG-1803
Update ordering on the progress bar and dashboard ENG-1532
…e the new objective components get lost down the page ENG-1532
Also revert the default amount of comminity activities shown on the component by default ENG-1532
Merge "Make a positive impact on young people in computing" and "Support your professional community" into a single grouping, deduplicating the 4 legacy activity slugs already shared between both. Also mark "Complete the I Belong programme as a school" as legacy ENG-1531
report_generation.rb special-cased secondary certificate's objective index by 1 specifically to skip this KS3 entry; that offset is no longer needed now that secondary certificate's programme_objectives shape matches primary certificate and i_belong's ENG-1260
Nothing instantiates ProgrammeCompletionRequired since the KS3 completion requirement was dropped from the secondary certificate ENG-1260
…econdary certificate ENG-1260
Remove the "Successfully complete the Subject knowledge certificate" enrol_copy bullet from all 5 secondary pathways, since KS3/CS Accelerator completion is no longer required Order programme_activity_groupings by sort_key before taking the first non-community group in Certificates::PathwaysController#show. Secondary now has 3 non-community groupings (All courses, CQF, PD) instead of 1, so relying on default row order was no longer safe to guarantee "All courses" is picked ENG-1534
These keys were superseded by @pathway.enrol_copy back in 2023 and have been unreferenced ever since - the how_to_enrol_1/2/3 body lines were never actually wired up in the first place ENG-1264
Removing these from the activities array (rather than marking legacy) left the existing programme_activity rows attached and active in staging/production, letting users complete CQF/PD via this grouping even though they're now standalone objectives
…instead of marking legacy Marking them legacy still let a Primary-only completion of these shared activities satisfy Secondary's community requirement, since Achievement has no programme scoping and users_completed doesn't check the legacy flag. CQF and PD now have their own per-programme "-secondary" activities for exactly this reason, so the old shared entries have no reason to remain attached here at all
Titles for activities like CQF embed an <a> tag directly, but this partial interpolated title as a plain string, so ERB auto-escaped the markup into visible literal text instead of a clickable link.
Update aside text and test ENG-2165
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the secondary certificate experience: CQF and Professional Development become standalone dashboard sections instead of being buried in the combined community activity list, KS3 is removed as a certificate completion requirement, and stale/outdated copy is cleaned up across the certificate pages and mailers.
CQF/PD as standalone dashboard sections
Removed KS3 as a certificate requirement
Copy and content cleanup
Bug fix
<a>tag directly, and the partial now uses sanitize to render it correctly, matching the pattern already used elsewhere for the same kind of title.