Conversation
anayeaye
reviewed
Sep 14, 2026
anayeaye
left a comment
anayeaye
left a comment
Contributor
There was a problem hiding this comment.
These changes look good--was the main update just to the airflow base url?
Comment on lines
+29
to
+37
| def _build_request_body_v3( | ||
| conf: Dict[str, Any], dag_id: str, note: str = "" | ||
| ) -> Dict[str, Any]: | ||
| """Build the request body for Airflow 3 API v2""" | ||
| return { | ||
| "conf": conf, | ||
| "dag_run_id": f"{dag_id}-{uuid.uuid4()}", | ||
| "note": note or "Run from GitHub Actions veda-data workflow", | ||
| } |
Contributor
There was a problem hiding this comment.
Is this the same as the _v2 request body? I can't see the difference
|
|
||
| api_token = b64encode(f"{username}:{password}".encode()).decode() | ||
|
|
||
| headers = { |
Contributor
There was a problem hiding this comment.
I like moving this logic to the common airflow_api.py!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/NASA-IMPACT/veda-architecture/issues/849
What Changed
scripts/airflow_api.pythat triggers that DAGs according to the version it identifies based on env var settings