Repository navigation
Gridap 0.20 - #56
Merged
Merged
Gridap 0.20#56
Conversation
Gridap was pinned to =0.19.9 because the engine reads its internal expression tree. This branch lifts the pin to 0.20 to see what the engine tests say. The HyperFEM job cannot resolve until HyperFEM also admits Gridap 0.20.
Gridap 0.20 builds the cell basis of a div-conforming space as linear_combination(M, PiolaMap(φ̂, Jt)) with the sign flips in a Diagonal change of basis M per cell, instead of PiolaMap(φ̂, Jt, |det Jt|, sign_flip). piola_basis, PiolaTable and cell_signs read both layouts (0.19 and 0.20). Spaces with scaled dofs (scale_dof) are rejected with a clear error.
…angelog, notes piola_basis and cell_signs read only the Gridap 0.20 layout. README, CHANGELOG, the CompatHelper note and the solver benchmark environment state Gridap 0.20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the package from Gridap 0.19.9 to the 0.20 series (
[compat] Gridap = "0.20"). Gridap 0.19 is no longer supported.What broke
Only H(div) fields. Gridap 0.20 reworked the pull-back machinery, and the cell basis of a div-conforming (Raviart–Thomas) space is now
with the sign flips in the change of basis
M(aDiagonalof ±1 per cell), instead ofPiolaMap(φ̂, Jt, |det Jt|, sign_flip).piola_basisdid not recognise it, so every H(div) form went to the Gridap fallback.What changes
src/tables.jl:piola_basis,PiolaTableandcell_signsread the 0.20 layout. Values and gradients follow the same formula as before, so kernels and tests are unchanged. Spaces built withscale_dof(new in 0.20) are rejected with a clear error.Project.toml, README, CHANGELOG, the CompatHelper note and the solver benchmark environment state Gridap 0.20.Everything else (probes, expression tree, Lagrangian tables, skeleton, Hessians, matrix-free, p-multigrid, states) needed no change.
Tests
Mac, Julia 1.13.0, Gridap 0.20.10, one process per test file:
test_hdiv.jlfailing;test_hdiv.jl5849/5849; tables, kernels, matrix-free, errors and fallback 35 795/35 795.Before merging
The
hyperfemCI job cannot resolve its environment while HyperFEMmainpinsGridap = "=0.19.9", so the requiredCIcheck stays red until HyperFEM moves to Gridap 0.20. Release afterwards as 0.3.0 (breaking dependency change).