Repository navigation
feat: add spec-kit reviewer agents and rename RFC vocabulary to plan - #31
Merged
Merged
Conversation
The timors-agentic-workflow preset used "RFC" as the label for the normative design document, carried over from an older workflow where an RFC was a separate file. In this preset plan.md plays that role, so the extra term added a false concept for readers of both Spec Kit and the preset. Switch "RFC" to "plan" across preset prose, structured review identifiers, generated report paths, reviewer packet filenames, and the reference filename, and update the preset architecture doc to match. The separate RFC-document workflow and its reviewer agents are left untouched.
The timors-agentic-workflow preset expects five independent reviewer roles, bound by matching each role description to a candidate agent description. This repository supplied no agents that fit those roles. Add five global reviewer agents, one per preset role, for both Claude Code and opencode, sharing a base body per role in .chezmoitemplates. Names carry the provider-neutral tier prefix used by the worker naming convention (most-capable, mid-tier); preset scoping lives in the agent description, which is the actual binding input.
The word "read-only" implied a reviewer writes nothing, yet every reviewer must write its review report. That ambiguity is a trap for a human or an agent reading the preset. State the constraint by its object instead: a reviewer does not modify the reviewed artifacts, and its only output is its review report, written outside the reviewed set. Reword the review lifecycle, binding, and documentation references, and add an explicit Output line to each reviewer packet.
MrPointer
force-pushed
the
feature/speckit-canonical-plan
branch
from
September 14, 2026 11:55
464409b to
8af38d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The
timors-agentic-workflowSpec Kit preset named its normative planning document "RFC", which collided with the separate real-RFC workflow, and it shipped no reviewer agents that its role-binding could actually select. This branch renames the preset's planning vocabulary from "RFC" to "plan", adds five reviewer agents (for both Claude Code and opencode) that fulfill the preset's reviewer roles, and reworks the reviewer constraint from the misleading "read-only" wording to an explicit no-modification rule.Key Decisions
🔤 RFC → plan vocabulary rename
Renamed the preset's planning artifacts, references, identifiers, and review-report paths from "RFC" to "plan" (for example
references/rfc-planning.md→references/plan-lifecycle.md,rfc-design/rfc-clarity/tasks-rfc-fidelityreviewers →plan-design/plan-clarity/tasks-plan-fidelity). This removes the name clash with the unrelated real-RFC workflow, whose own documents intentionally keep the "RFC" term.🤖 Preset reviewer agents
Added five reviewer agents matching the preset's roles: plan-design, plan-clarity, tasks-plan-fidelity, tasks-executability, and component-docs. Each has a shared base template in
.chezmoitemplates/consumed by thin Claude (dot_claude/agents/) and opencode (private_dot_config/opencode/agents/) wrappers. Names are tier-prefixed (<tier>-<role>) so the preset's description-based binding can select a single clear fit; the preset scope lives in the description, not the name.🛡️ Reviewer constraint reworded
Replaced "read-only" across the preset and the new agents with an explicit rule: a reviewer does not modify the artifacts it reviews and writes only its review report, outside the reviewed set. "Read-only" was self-contradictory because reviewers must write their reports; the object-stated wording removes that trap.
🔄 Before & After