feat(report): put the raw schema name in the header tooltip - #432
Merged
Conversation
A relabelled Report column now carries its raw wire name as the header tooltip (`MoonDataTableColumn::tooltip`, MoonUI fix/data-table-hover- and-header-tooltip), so the name a support chat quotes stays one hover away; columns whose label already is the raw name get no tooltip. The chart engine's palette literal names the new `table_hover` key. Depends on that MoonUI change: merge it and bump the MoonUI pin before this lands, or the build fails on the missing builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A relabelled Report column now carries its raw wire name as a header tooltip, so the name a support chat quotes stays one hover away; columns whose label already is the raw name get none. Needs MoonUI's new
MoonDataTableColumn::tooltipandtable_hoverpalette key (Moonbot-Tech/MoonUI#61), so the first commit bumps the MoonUI pin to that merge — only the MoonUI source hash moved in the lock (cargo fetch --lockedproves it).How to verify
cargo test -p moon-ui-gpui(1439 unit + theme_contract green on the new pin)isshort; hover a row on the light theme: the row highlights